[2.x] Support setting extra attributes for navigation items #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3a0c279.
Inspired by Filament
May want to revert this later as it makes sense for user added data to be last, but this preserves the current attribute order for now
caendesilva
force-pushed
the
support-extra-attributes-for-navigation-items
branch
from
9d7c1cb
to
93cef20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unify-the-navigation-api #1824 +/- ##
============================================================
Coverage 100.00% 100.00%
+ Complexity 1847 1845 -2
============================================================
Files 189 189
Lines 4889 4884 -5
============================================================
- Hits 4889 4884 -5 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
support-extra-attributes-for-navigation-items
branch
from
38ac1a4
to
c087bbf
Compare
caendesilva
force-pushed
the
support-extra-attributes-for-navigation-items
branch
from
66c6e66
to
33e40d8
Compare
caendesilva
force-pushed
the
support-extra-attributes-for-navigation-items
branch
from
baa8d8d
to
ed672ce
Compare
Claude is just insanely good
caendesilva
force-pushed
the
support-extra-attributes-for-navigation-items
branch
from
ed672ce
to
3f7c34b
Compare
caendesilva
force-pushed
the
support-extra-attributes-for-navigation-items
branch
from
e110412
to
798d363
Compare
caendesilva
force-pushed
the
support-extra-attributes-for-navigation-items
branch
from
fb69b00
to
c8a72a8
Compare
We "lose" out on the null defaults, but they don't offer any value anyways.
caendesilva
force-pushed
the
support-extra-attributes-for-navigation-items
branch
from
9106b7a
to
6a076b8
Compare
caendesilva
force-pushed
the
support-extra-attributes-for-navigation-items
branch
from
1daf9e9
to
912f7b2
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1818, please see the changelog there.